From 67df40dce61fe0216fa645da9ffb8e008ebcc31c Mon Sep 17 00:00:00 2001 From: Rico van Zelst Date: Tue, 7 Nov 2023 08:38:17 +0100 Subject: [PATCH] fix: optimize queries --- app/Http/Controllers/HomeController.php | 11 ++++++----- app/View/Components/home/recent_skins.php | 2 +- .../views/components/home/recent_skins.blade.php | 4 ++-- resources/views/home.blade.php | 12 ++++++------ 4 files changed, 15 insertions(+), 14 deletions(-) diff --git a/app/Http/Controllers/HomeController.php b/app/Http/Controllers/HomeController.php index 686ae66..fedbb02 100644 --- a/app/Http/Controllers/HomeController.php +++ b/app/Http/Controllers/HomeController.php @@ -9,16 +9,17 @@ class HomeController extends Controller { public function index() { - $skins = Cache::remember('skins', 60 * 4, function () { - return ChampionSkin::orderBy('release_date', 'desc')->get(); + $upcomingSkins = Cache::remember('upcomingSkins_home', 60 * 4, function () { + return ChampionSkin::where('availability', 'Upcoming')->orderBy('release_date', 'desc')->get(); }); - $upcomingSkins = Cache::remember('upcomingSkins', 60 * 4, function () use ($skins) { - return $skins->where('availability', 'Upcoming'); + $latestSkins = Cache::remember('latestSkins_home', 60 * 4, function () { + return ChampionSkin::where('availability', 'Available')->orderBy('release_date', 'desc')->take(9)->get(); }); + return view('home', [ - 'skins' => $skins, + 'latestSkins' => $latestSkins, 'upcomingSkins' => $upcomingSkins, ]); } diff --git a/app/View/Components/home/recent_skins.php b/app/View/Components/home/recent_skins.php index 666478f..52c5733 100644 --- a/app/View/Components/home/recent_skins.php +++ b/app/View/Components/home/recent_skins.php @@ -11,7 +11,7 @@ class recent_skins extends Component /** * Create a new component instance. */ - public function __construct(public array $skins) + public function __construct(public array $latestSkins) { } diff --git a/resources/views/components/home/recent_skins.blade.php b/resources/views/components/home/recent_skins.blade.php index d44d3b1..1559164 100644 --- a/resources/views/components/home/recent_skins.blade.php +++ b/resources/views/components/home/recent_skins.blade.php @@ -14,14 +14,14 @@

- @foreach ($skins as $skin) + @foreach ($latestSkins as $skin) @if ($loop->index < 9)
{{ $skin->skin_name }} Splash Art + src="{{ $skin->getSkinImageAttribute() }}" alt="{{ $skin->skin_name }} Splash Art">

{{ $skin->skin_name }}

Released diff --git a/resources/views/home.blade.php b/resources/views/home.blade.php index 53ab0bb..26758b6 100644 --- a/resources/views/home.blade.php +++ b/resources/views/home.blade.php @@ -28,12 +28,12 @@ - - -@if($upcomingSkins != []) - -@endif - + + + @if ($upcomingSkins != []) + + @endif +