Archive/HeimerdingerLoL
1
0
Fork 0
mirror of https://github.com/rico-vz/HeimerdingerLoL.git synced 2025-12-06 10:10:48 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: Handle exceptions in image processing functions

Browse Source 
- Catch exceptions when reading image content to prevent errors.
- Adjust image resizing dimensions for better display.
This commit is contained in:
Rico van Zelst
2024-03-28 10:34:16 +01:00
parent 5b55e21659
commit 998f386f20
3 changed files with 13 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/Helpers/HelperFunctions.php
View File

@@ -20,9 +20,13 @@ function getAverageColorFromImageUrl($imageUrl): string
{
$imgManager = new ImageManager(new Driver());
try {
$img = $imgManager->read(file_get_contents($imageUrl));
} catch (Exception $e) {
return '#904f2c';
}
$img->resize(24, 24);
$img->resize(32, 32);
$totalR = 0;
$totalG = 0;

2
app/Http/Controllers/ChampionController.php
View File

@@ -37,7 +37,7 @@ class ChampionController extends Controller
$splashColor = Cache::remember(
'championSplashColorCache' . $champion->slug,
$sixMonthsInSeconds,
static fn () => getAverageColorFromImageUrl($champion->getChampionImageAttribute())
static fn () => getAverageColorFromImageUrl('https://wsrv.nl/?url=' . $champion->getChampionImageAttribute())
);
$champion->splash_color = $splashColor;

2
app/Http/Controllers/ChampionSkinController.php
View File

@@ -63,7 +63,7 @@ class ChampionSkinController extends Controller
$splashColor = Cache::remember(
'championSkinSplashColorCache' . $championSkin->slug,
60 * 60 * 120,
static fn () => getAverageColorFromImageUrl($championSkin->getSkinImageAttribute())
getAverageColorFromImageUrl('https://wsrv.nl/?url=' . $championSkin->getSkinImageAttribute())
);
$skin->splash_color = $splashColor;