From 99c8f9ee1773b39e2ced4f1dbbd441fbae1bacc6 Mon Sep 17 00:00:00 2001 From: Rico van Zelst Date: Fri, 16 May 2025 14:15:01 +0200 Subject: [PATCH] fix: remove unused splash_color --- app/Http/Controllers/ChampionController.php | 15 +++------------ app/Http/Controllers/ChampionSkinController.php | 8 -------- 2 files changed, 3 insertions(+), 20 deletions(-) diff --git a/app/Http/Controllers/ChampionController.php b/app/Http/Controllers/ChampionController.php index 7efb7e7..a305489 100644 --- a/app/Http/Controllers/ChampionController.php +++ b/app/Http/Controllers/ChampionController.php @@ -15,9 +15,9 @@ class ChampionController extends Controller { $eightHoursInSeconds = 60 * 60 * 8; - $champions = Cache::remember('championsListAllCache', $eightHoursInSeconds, static fn () => Champion::orderBy('name')->get()); + $champions = Cache::remember('championsListAllCache', $eightHoursInSeconds, static fn() => Champion::orderBy('name')->get()); - $roles = Cache::remember('championsRolesCache', $eightHoursInSeconds, static fn () => ChampionRoles::orderBy('champion_name')->get()); + $roles = Cache::remember('championsRolesCache', $eightHoursInSeconds, static fn() => ChampionRoles::orderBy('champion_name')->get()); return view('champions.index', ['champions' => $champions, 'roles' => $roles]); } @@ -28,20 +28,11 @@ class ChampionController extends Controller public function show(Champion $champion) { $threeDaysInSeconds = 60 * 60 * 24 * 3; - $sixMonthsInSeconds = 60 * 60 * 24 * 30 * 6; - $champion = Cache::remember('championShowCache'.$champion->slug, $threeDaysInSeconds, static fn () => $champion->load('streamers', 'skins', 'lanes')); + $champion = Cache::remember('championShowCache' . $champion->slug, $threeDaysInSeconds, static fn() => $champion->load('streamers', 'skins', 'lanes')); $streamers = $champion->load('streamers')->streamers; - $splashColor = Cache::remember( - 'championSplashColorCache'.$champion->slug, - $sixMonthsInSeconds, - static fn () => getAverageColorFromImageUrl('https://wsrv.nl/?url='.$champion->getChampionImageAttribute(true)) - ); - - $champion->splash_color = $splashColor; - return view('champions.show', ['champion' => $champion, 'streamers' => $streamers]); } } diff --git a/app/Http/Controllers/ChampionSkinController.php b/app/Http/Controllers/ChampionSkinController.php index 5f7e7dd..0195dd7 100644 --- a/app/Http/Controllers/ChampionSkinController.php +++ b/app/Http/Controllers/ChampionSkinController.php @@ -63,14 +63,6 @@ class ChampionSkinController extends Controller static fn () => $championSkin->load('champion', 'chromas') ); - $splashColor = Cache::remember( - 'championSkinSplashColorCache'.$championSkin->slug, - 60 * 60 * 120, - static fn () => getAverageColorFromImageUrl('https://wsrv.nl/?url='.$championSkin->getSkinImageAttribute(true)) - ); - - $skin->splash_color = $splashColor; - return view('skins.show', ['skin' => $skin]); }