RWU/EasyDrop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

#39 Rewrote JSON accessing

Browse Source
This commit is contained in:
Marvin Scham
2023-05-24 00:24:01 +02:00
parent c09127200b
commit 17bd6ab587
1 changed files with 16 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
src/main/java/de/rwu/easydrop/api/client/AmazonProductDataSource.java
View File

@@ -7,8 +7,9 @@ import java.net.HttpURLConnection;
import java.net.MalformedURLException; import java.net.MalformedURLException;
import java.net.URL; import java.net.URL;
import org.json.JSONException; import com.jayway.jsonpath.JsonPath;
import org.json.JSONObject; import com.jayway.jsonpath.PathNotFoundException;
import com.jayway.jsonpath.ReadContext;
import de.rwu.easydrop.api.dto.ProductDTO; import de.rwu.easydrop.api.dto.ProductDTO;
@@ -77,8 +78,7 @@ public final class AmazonProductDataSource implements DataSource {
} }
reader.close(); reader.close();
JSONObject offer = new JSONObject(response.toString()).getJSONObject("featuredOffer"); buildProductDTO(product, response.toString());
buildProductDTO(product, offer);
} catch (IOException e) { } catch (IOException e) {
throw new IllegalArgumentException("Couldn't fulfill Amazon API request"); throw new IllegalArgumentException("Couldn't fulfill Amazon API request");
} }
@@ -90,29 +90,22 @@ public final class AmazonProductDataSource implements DataSource {
* Enriches a ProductDTO with API-gathered data. * Enriches a ProductDTO with API-gathered data.
* *
* @param product Unfinished ProductDTO * @param product Unfinished ProductDTO
* @param offer Product data * @param json Product data
* @return Finished ProductDTO * @return Finished ProductDTO
*/ */
private ProductDTO buildProductDTO(final ProductDTO product, final JSONObject offer) { public ProductDTO buildProductDTO(final ProductDTO product, final String json) {
String root = "$.featuredOffer.";
ReadContext ctx = JsonPath.parse(json);
try { try {
product.setDataOrigin(DATA_ORIGIN); product.setDataOrigin(DATA_ORIGIN);
product.setAvailable(offer product.setAvailable(
.getString("availability") ctx.read(root + "availability", String.class).equals("available"));
.equals("available")); product.setCurrentPrice(ctx.read(root + "price.value.amount", double.class));
product.setCurrentPrice(offer product.setDeliveryPrice(
.getJSONObject("price") ctx.read(root + "shippingOptions[0].shippingCost.value.amount", double.class));
.getJSONObject("value") product.setMerchant(ctx.read(root + "merchant.name", String.class));
.getDouble("amount")); } catch (PathNotFoundException e) {
product.setDeliveryPrice(offer
.getJSONArray("shippingOptions")
.getJSONObject(0)
.getJSONObject("shippingCost")
.getJSONObject("value")
.getDouble("amount"));
product.setMerchant(offer
.getJSONObject("merchant")
.getString("name"));
} catch (JSONException e) {
// Pass, allow incomplete ProductDTO to pass for later validation // Pass, allow incomplete ProductDTO to pass for later validation
} }