RWU/EasyDrop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Provided descriptions + todo for empty classes

Browse Source
This commit is contained in:
Marvin Scham
2023-05-23 07:27:16 +02:00
parent d1d15f79ec
commit 4649b58859
7 changed files with 40 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/main/java/de/rwu/easydrop/api/client/AmazonProductDataSource.java
View File

@@ -50,8 +50,8 @@ public final class AmazonProductDataSource implements DataSource {
}
@Override
public ProductDTO getProductDTOById(final String productId) {
JSONObject offer = null;
public ProductDTO getProductDTOById(final String productId) throws IllegalArgumentException {
StringBuilder response = new StringBuilder();
ProductDTO product = new ProductDTO(productId, DATA_ORIGIN);
try {
@@ -73,27 +73,21 @@ public final class AmazonProductDataSource implements DataSource {
if (responseCode == HttpURLConnection.HTTP_OK) {
reader = new BufferedReader(new InputStreamReader(connection.getInputStream()));
} else {
return product;
throw new IllegalArgumentException(
"Amazon API responded with error code " + responseCode);
}
String line;
StringBuilder response = new StringBuilder();
while ((line = reader.readLine()) != null) {
response.append(line);
}
reader.close();
offer = new JSONObject(response.toString());
} catch (IOException e) {
e.printStackTrace();
}
if (offer == null) {
return product;
throw new IllegalArgumentException("Couldn't fulfill Amazon API request");
}
try {
offer = offer.getJSONObject("featuredOffer");
JSONObject offer = new JSONObject(response.toString()).getJSONObject("featuredOffer");
product.setDataOrigin(DATA_ORIGIN);
product.setAvailable(offer
@@ -113,7 +107,7 @@ public final class AmazonProductDataSource implements DataSource {
.getJSONObject("merchant")
.getString("name"));
} catch (JSONException e) {
return product;
// Pass, allow incomplete ProductDTO to pass for later validation
}
return product;